-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(iroh): Feature-flag the doc test #2983
Conversation
This test can only work if the feature is enabled. Feature-flag the entire test contents.
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2983/docs/iroh/ Last updated: 2024-12-02T10:55:52Z |
will still fail in |
Do we support cargo doc without all features? How does docs.rs run cargo doc? Should we not make sure CI fails on these things? |
I think we should, because locally the initial thing you do is run
we probably should |
We have
So I think everything will work fine. Of course you can argue this is not a great local experience. But neither is having some of the docs accidentally hidden when building locally. Not sure what to do here... |
no need to hide things, just don't make it a link |
- Checks docs with default features - Checks doc tests compile with all feature combinations
#![cfg_attr( | ||
not(feature = "discovery-local-network"), | ||
doc = "`LocalSwarmDiscovery`" | ||
)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful 🤮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You asked for this 😝
Description
This test can only work if the feature is enabled. Feature-flag the
entire test contents.
Closes #2950.
Breaking Changes
Notes & open questions
Change checklist