fix(iroh-relay): removes deadlock in Clients
#3099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2025 23:26
Also downgrades "stream terminated" from a `warn` to a `trace`, so we don not get an warning everytime a connection to the relay closes
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3099/docs/iroh/ Last updated: 2025-01-07T18:24:43Z |
|
Can confirm this fixes the issue for me. |
flub
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
LGTM but let's wait for @dignifiedquire as he wrote this I think
|
Okay, added a The thing that really sold it for me was that it is now easy for this deadlock to show up in a test if there are future refactors. It will be difficult to explicitly remove the |
dignifiedquire
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the deadlock that was a bit hidden due to
DashMap.Added
clientparameter tounregisterto explicitly drop before attempting to call into theclientsDashMapagain.Notes & open questions
The
warnlog for stream termination seems a little fear-mongering, but I'm not sure the best way to "downgrade" this, as we seem to rely on this error in tests likeendpoint_relay_connect_loop. Ended up leaving it as is.Change checklist