fix(witai): Enforce the request timeout #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0th1ng-else
force-pushed
the
link-req
branch
3 times, most recently
from
3b71cc8
to
e150f66
Compare
We have added the timeout even for the streaming request. So now it should take max 20sec. Plus I assume we take up to 20sec to transform wav file. We should fit into 60sec telegram timeout. I have added an env variable to control the behavior
n0th1ng-else
force-pushed
the
link-req
branch
2 times, most recently
from
4c1469b
to
c1094a5
Compare
Previous approach with timeout did not work. So farr the AbortSignal pattern seems to be working fine. This commit reverts the old implementations and assignes the AbortSignal for the WitAI requests.
n0th1ng-else
force-pushed
the
link-req
branch
from
c1094a5
to
f82cc00
Compare
|
Kudos, SonarCloud Quality Gate passed! |
n0th1ng-else
changed the title
|
🎉 This PR is included in version 4.23.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added the timeout even for the streaming request. So now
it should take max 20sec. Plus I assume we take up to 20sec
to transform wav file. We should fit into 60sec telegram timeout. I have added an env variable to control the behavior
Previous approach with timeout did not work. So farr the AbortSignal pattern seems to be working fine. This commit
reverts the old implementations and assignes the AbortSignal for the WitAI requests.