Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Google Vertex Chat Model Node): Add an option to specify GCP region #12300

Conversation

burivuhster
Copy link
Contributor

Summary

This PR adds an option to choose GCP Region for the Google API credentials. For the moment, the only node affected by this change is the Google Vertex AI Chat Model.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@burivuhster burivuhster force-pushed the ai-365-community-issue-google-vertex-ai-chat-model-node-missing-gcp branch from e02eb0f to 8cd609e Compare December 19, 2024 09:21
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Dec 19, 2024
…at-model-node-missing-gcp

# Conflicts:
#	packages/nodes-base/credentials/GoogleApi.credentials.ts
@burivuhster burivuhster changed the title feat(Google Vertex AI Chat Model Node): Add an option to specify GCP region feat(Google Vertex Chat Model Node): Add an option to specify GCP region Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@burivuhster burivuhster marked this pull request as ready for review December 20, 2024 11:38
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Dec 31, 2024

n8n    Run #8616

Run Properties:  status check passed Passed #8616  •  git commit fee029d124: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Project n8n
Branch Review ai-365-community-issue-google-vertex-ai-chat-model-node-missing-gcp
Run status status check passed Passed #8616
Run duration 04m 45s
Commit git commit fee029d124: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 burivuhster 🗃️ e2e/*
Committer Eugene Molodkin
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 485
View all changes introduced in this branch ↗︎

OlegIvaniv
OlegIvaniv previously approved these changes Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 6, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

OlegIvaniv
OlegIvaniv previously approved these changes Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

github-actions bot commented Jan 7, 2025

✅ All Cypress E2E specs passed

@burivuhster burivuhster merged commit 30f9c03 into master Jan 7, 2025
57 checks passed
@burivuhster burivuhster deleted the ai-365-community-issue-google-vertex-ai-chat-model-node-missing-gcp branch January 7, 2025 14:10
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants