Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editor): Add support for project icons #12349

Merged
merged 43 commits into from
Dec 27, 2024
Merged

feat(editor): Add support for project icons #12349

merged 43 commits into from
Dec 27, 2024

Conversation

MiloradFilipovic
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic commented Dec 23, 2024 •
edited
Loading

Summary

Implementing custom project icon selector:
image

Rendering the project icon in UI:
image

Closes ADO-2791

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@MiloradFilipovic MiloradFilipovic self-assigned this Dec 23, 2024
@MiloradFilipovic MiloradFilipovic marked this pull request as draft December 23, 2024 14:10
@MiloradFilipovic MiloradFilipovic changed the title Ado 2791 project icons feat(editor): Add support for project icons Dec 23, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Dec 23, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.71840% with 105 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...src/components/N8nIconPicker/IconPicker.stories.ts 0.00% 47 Missing ⚠️
packages/editor-ui/src/views/ProjectSettings.vue 27.69% 47 Missing ⚠️
...-ui/src/components/Projects/ProjectSharingInfo.vue 50.00% 4 Missing ⚠️
...system/src/components/N8nIconPicker/IconPicker.vue 97.39% 2 Missing and 1 partial ⚠️
packages/editor-ui/src/api/projects.api.ts 0.00% 2 Missing ⚠️
packages/editor-ui/src/stores/projects.store.ts 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@MiloradFilipovic
👌 Moving icon selector inline with project input
023c378
@MiloradFilipovic
Merge branch 'master' into ADO-2791-project-icons
49565e8
@MiloradFilipovic
⚡️ Backend support for project icons
7571763
@MiloradFilipovic
✨ Rendering saved project icons in the UI
47e7575
@MiloradFilipovic
⚡️ Getting types in line
b25c0b1
@MiloradFilipovic
⚡️ Updating project icon when project is loaded
7585fd8
@MiloradFilipovic
✨ Automatically saving project icon update
ea0b0a2
@MiloradFilipovic
⚡️ Updating project icon in settings header
ae51e46
@MiloradFilipovic
⚡️ Unifying icon type on backend
dbbad87
@MiloradFilipovic
✨ Adding icon to SlimProject
e082eb8
@MiloradFilipovic
✨ Implemented ProjectIcon component
16baab7
@MiloradFilipovic
⚡️ Using ProjectIcon component in sharing modals
03034be
@MiloradFilipovic
💄 Showing icons in collapsed menu
55bab08
@MiloradFilipovic
Merge branch 'master' into ADO-2791-project-icons
d53aafc
@MiloradFilipovic
🔨 Cleanup
c3aac38
@MiloradFilipovic
🔨 More typing cleanup
6b591fc
@MiloradFilipovic
⚡️ Using model value for IconPicker
0483fb4
@MiloradFilipovic MiloradFilipovic marked this pull request as ready for review December 27, 2024 09:07
@MiloradFilipovic MiloradFilipovic requested a review from a team as a code owner December 27, 2024 09:07
netroy
netroy requested changes Dec 27, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the one comment, LGTM

packages/cli/src/databases/migrations/sqlite/index.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

⚠️ Visual regressions found: 11

@cypress Cypress
Copy link

cypress bot commented Dec 27, 2024

n8n    Run #8487

Run Properties:  status check passed Passed #8487  •  git commit c293679cca: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review ADO-2791-project-icons
Run status status check passed Passed #8487
Run duration 04m 40s
Commit git commit c293679cca: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad FIlipović
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 484
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit 9117718 into master Dec 27, 2024
44 of 45 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ADO-2791-project-icons branch December 27, 2024 18:00
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Merged
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.1

@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

1 similar comment
@janober
Copy link
Member

janober commented Jan 9, 2025

Got released with n8n@1.74.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees

@MiloradFilipovic MiloradFilipovic

Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiloradFilipovic @janober @netroy