wip #4
Open
wip #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- simplify ECS Creds parser - fixup circular dependency to amazonCredentialsLoader - minor cleanup
- remove configurations for providers where not necessary - simplifying the code for Handlers - minor fixes to ProviderHelpers
nabuskey
force-pushed
the
feature/ecs-dynamic-account
branch
2 times, most recently
from
6d3536c to
84a6a26
Compare
nabuskey
force-pushed
the
feature/ecs-dynamic-account
branch
from
3bc3073 to
9eec79b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure why this is needed.