Skip to content

Commit

Permalink
Update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
hewanadun committed Dec 14, 2024
1 parent 3169310 commit 47df746
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Documentation of release versions of `nacc-form-validator`
* Refactors the tests to be more modularized so that they're more manageable
* Refactors logic for `compare_values` by moving it to its own utility method and allows comparing to null values
* Fixes issue where `datastore` was not being set for the temp validator in `_check_subschema_valid`, causing nested conditions with previous records to not evaluate correctly
* Overrides `_validate_nullable` method to drop custom rule definitions that cannot be evaluated for null values

## 0.3.0

Expand Down
1 change: 0 additions & 1 deletion tests/test_rules_compare_age.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,5 +185,4 @@ def test_compare_age_null_base(create_nacc_validator):
nv = create_nacc_validator(schema)
assert not nv.validate(
nv.cast_record({'frmdate': '', 'birthyr': 2024, 'behage': 50}))
print(nv.errors)
assert nv.errors == {'frmdate': ['null value not allowed']}

0 comments on commit 47df746

Please sign in to comment.