Adds more testing/error verbosity, fixes nested previous records bug #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly just testing for weird situations, but also makes two algorithmic updates:
datastore
was not being set for the temp validator in_check_subschema_valid
, causing nested conditions with previous records to not evaluate correctly (e.g. A1EDUC
case, wherecompare_with
previous record was nested inside atemporalrules
)compatibility
errors to be more verbose - before we were not reporting what thethen/else
conditions were and so it was impossible to tell what was wrong if athen/else
condition failed. Unfortunately that does mean the error messages are longer/uglier though.