Updates temporalrules to be able to swap order of operations #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hewanadun
previously approved these changes
Nov 20, 2024
nacc_form_validator/errors.py
Outdated
Comment on lines
92
to
93
| "{1} in current visit for if {2} in previous visit then {3} " + | ||
| "in current visit - temporal rule no: {0}", |
There was a problem hiding this comment.
Remove "in current visit" => "{1} for if {2} in previous visit then {3} in current visit - temporal rule no: {0}".
Do the same in 3004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely for FVP rules where we have to check that previous visit has a valid entry if the current visit puts 777 (provided at previous visit)