Add scoring function rule #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hewanadun
previously approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Looks good!
Couple of minor fixes in _score_variables
- Change the warning to
"Field {key} not present or blank, skipping validation" - Passing
valuein line 1216 is not correct with the current error message. - We can change error message for
SCORING_INVALIDto"Provided value {0} does not match the expected score"[it's difficult to include the score here since final score is generated by applyinglogic, we can include the logic formula]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a scoring function rule required for C2F scoring rules.