Fix vertical align #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Also, added test cases where the difference is obvious after the correction |
Contributor
Author
|
This is also crucial when balancing the x coordinates of subgraphs (that I am developing currently in another branch) |
Owner
|
Can you please attach pictures to the pull request? |
Contributor
Author
|
Before this pr: After pr: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr fixes on some of the errors regarding the implementation of the algorithm in the paper "Fast and Simple Horizontal Coordinate Assignment"
For some reason the scanning on top bottom direction was not implemented instead additional scanning on left right direction.
Also, the step of getting final coords from different 4 variations of algo uses the mean, not the average median. This is also corrected.