Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in the ecdsa Sign procedure ? #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fabien-Morrow
Copy link

I think there's a small error in the ECDSA Sign procedure described in this page. r will not always be smaller than n, r is just smaller than p. I propose this small change to ensure r is always smaller than n, keeping things simple at this step, and letting the reader to dive into malleability stuff once he grabbed the procedure.

I think there's a small error in the ECDSA Sign procedure described in this page.
r will not always be smaller than n, r is just smaller than p.
I propose this small change to ensure r is always smaller than n, keeping things simple at this step, and letting the reader to dive into malleability stuff once he grabbed the procedure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant