Align build requirements with latest ndn-cxx + misc cleanups #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pesa
commented
Nov 28, 2023
wscript
Outdated
| boost_libs = ['system'] | ||
| boost_libs = [] |
There was a problem hiding this comment.
Boost.System is header-only since 1.69, no need to link to the compiled library anymore (which is just a compat stub now)
Pesa
commented
Nov 28, 2023
| @@ -32,7 +33,7 @@ def options(opt): | |||
| help='Build unit tests') | |||
|
|
|||
| optgrp.add_option('--with-compression', action='store_true', default=False, | |||
| dest='with_compression', help='Build with state vector compression extension') | |||
There was a problem hiding this comment.
dest is redundant in this case
Pesa
commented
Nov 28, 2023
Comment on lines
-104
to
-105
| vnum=VERSION, | ||
| cnum=VERSION, |
There was a problem hiding this comment.
vnum and cnum are meaningful only for shared libraries, hence moved to shlib below.
|
Please ignore the CI failure with clang 18, it's unrelated (https://redmine.named-data.net/issues/5300) |
pulsejet
approved these changes
Nov 28, 2023
Guess I'll have to make do with just 7, 8, 9, 10, 11, 12, 13, 14, 15, 16 and 17 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.