Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Releases: ensapi@1.7.0 ensindexer@1.7.0 ensadmin@1.7.0 ensrainbow@1.7.0 fallback-ensapi@1.7.0 @ensnode/datasources@1.7.0 @ensnode/ensrainbow-sdk@1.7.0 @ensnode/ensnode-schema@1.7.0 @ensnode/ensnode-react@1.7.0 @ensnode/ensnode-sdk@1.7.0 @ensnode/ponder-sdk@1.7.0 @ensnode/ponder-subgraph@1.7.0 @ensnode/shared-configs@1.7.0 @docs/ensnode@1.7.0 @docs/ensrainbow@1.7.0 @docs/mintlify@1.7.0 @namehash/ens-referrals@1.7.0 @namehash/namehash-ui@1.7.0 [skip ci]
github-actions
bot
force-pushed
the
changeset-release/main
branch
from
3c1490c to
145d586
Compare
Contributor
Greptile SummaryThis is an automated Changesets release PR that bumps all packages in the monorepo from Key changes:
Issue found:
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["ensapi@1.7.0\n(minor: 2 BREAKING + 1 new feature)"] --> B["@ensnode/datasources@1.7.0"]
A --> C["@ensnode/ensnode-schema@1.7.0"]
A --> D["@ensnode/ensnode-sdk@1.7.0"]
A --> E["@ensnode/ponder-subgraph@1.7.0"]
A --> F["@namehash/ens-referrals@1.7.0"]
D --> B
G["ensadmin@1.7.0\n(patch: dep bump)"] --> B
G --> C
G --> H["@ensnode/ensnode-react@1.7.0"]
G --> D
G --> I["@namehash/namehash-ui@1.7.0"]
H --> D
I --> B
I --> H
I --> D
J["ensindexer@1.7.0\n(patch: dep bump)"] --> B
J --> K["@ensnode/ensrainbow-sdk@1.7.0"]
J --> C
J --> D
J --> L["@ensnode/ponder-sdk@1.7.0"]
M["ensrainbow@1.7.0\n(patch: dep bump)"] --> K
M --> D
N["fallback-ensapi@1.7.0\n(patch: dep bump)"] --> B
N --> D
style A fill:#f96,stroke:#c00,color:#000
Last reviewed commit: 145d586 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+7
to
+12
| - [#1719](https://github.com/namehash/ensnode/pull/1719) [`4cb6dee`](https://github.com/namehash/ensnode/commit/4cb6dee2a0198b630b4efdd02eb71c36c7d38025) Thanks [@shrugs](https://github.com/shrugs)! - ENSNode GraphQL API: BREAKING: Removed `ENSv1Domain.children` in favor of `Domain.subdomains`. | ||
|
|
||
| - [#1719](https://github.com/namehash/ensnode/pull/1719) [`4cb6dee`](https://github.com/namehash/ensnode/commit/4cb6dee2a0198b630b4efdd02eb71c36c7d38025) Thanks [@shrugs](https://github.com/shrugs)! - ENSNode GraphQL API: Introduce `*Connection.totalCount` for all `*Connection` fields, following the Relay specification. | ||
|
|
||
| - [#1719](https://github.com/namehash/ensnode/pull/1719) [`4cb6dee`](https://github.com/namehash/ensnode/commit/4cb6dee2a0198b630b4efdd02eb71c36c7d38025) Thanks [@shrugs](https://github.com/shrugs)! - ENSNode GraphQL API: BREAKING: Removed `Domain.subdomainCount` in favor of `Domain.subdomains.totalCount`. | ||
|
|
Contributor
There was a problem hiding this comment.
Breaking changes versioned as minor bump
Two of the three ensapi changes in this release are explicitly labelled BREAKING:
- Removed
ENSv1Domain.children(replaced byDomain.subdomains) - Removed
Domain.subdomainCount(replaced byDomain.subdomains.totalCount)
According to Semantic Versioning (semver), breaking/incompatible API removals should trigger a major version increment (e.g. 1.6.0 → 2.0.0), not a minor one (1.6.0 → 1.7.0). The root cause is in the now-deleted changeset files (.changeset/eager-parrots-follow.md and .changeset/shiny-cameras-judge.md), which both used "ensapi": minor instead of "ensapi": major.
Consumers relying on ENSv1Domain.children or Domain.subdomainCount may upgrade to 1.7.0 without expecting breakage, since a minor bump typically signals backwards-compatible new features. If this project intentionally deviates from strict semver (e.g. all breaking changes before a stable v2 are kept at minor), that policy should be documented clearly in the release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@namehash/ens-referrals@1.7.0
Patch Changes
@ensnode/ensnode-react@1.7.0
Patch Changes
@ensnode/ensnode-sdk@1.7.0
Patch Changes
@namehash/namehash-ui@1.7.0
Patch Changes
@ensnode/datasources@1.7.0
@ensnode/ensnode-schema@1.7.0
@ensnode/ensrainbow-sdk@1.7.0
@ensnode/ponder-sdk@1.7.0
@ensnode/ponder-subgraph@1.7.0
ensapi@1.7.0
Minor Changes
#1719
4cb6deeThanks @shrugs! - ENSNode GraphQL API: BREAKING: RemovedENSv1Domain.childrenin favor ofDomain.subdomains.#1719
4cb6deeThanks @shrugs! - ENSNode GraphQL API: Introduce*Connection.totalCountfor all*Connectionfields, following the Relay specification.#1719
4cb6deeThanks @shrugs! - ENSNode GraphQL API: BREAKING: RemovedDomain.subdomainCountin favor ofDomain.subdomains.totalCount.Patch Changes
ensadmin@1.7.0
Patch Changes
ensindexer@1.7.0
Patch Changes
ensrainbow@1.7.0
Patch Changes
fallback-ensapi@1.7.0
Patch Changes
@docs/mintlify@1.7.0
@docs/ensnode@1.7.0
@docs/ensrainbow@1.7.0
@ensnode/shared-configs@1.7.0