Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ChaCha20/Poly1305 #26

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Add support for ChaCha20/Poly1305 #26

merged 2 commits into from
Aug 27, 2024

Conversation

pulsastrix
Copy link
Member

Just like #24, just for ChaCha20/Poly1305.

Also solves some minor issues with imports in no_std environments using the RustCrypto backend and ensures the pipeline also tests rustcrypto with no_std.

Depends on #25.
Closes #18.

@pulsastrix pulsastrix added the enhancement New feature or request label Aug 27, 2024
@pulsastrix pulsastrix added this to the Version 0.5 milestone Aug 27, 2024
@pulsastrix pulsastrix self-assigned this Aug 27, 2024
@pulsastrix pulsastrix mentioned this pull request Aug 27, 2024
Closed
14 tasks
@coveralls
Copy link

coveralls commented Aug 27, 2024 •
edited
Loading

Coverage Status

coverage: 85.242% (+0.09%) from 85.156%
when pulling 7909305 on chacha_poly
into 47f4982 on main.

@pulsastrix pulsastrix marked this pull request as ready for review August 27, 2024 22:21
falko17
falko17 previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@falko17 falko17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two very minor comments, so I'll approve already.

src/token/cose/encrypted/mod.rs Outdated Show resolved Hide resolved
tests/dcaf_cose_examples/chacha-poly/empty_payload.json Outdated Show resolved Hide resolved
@pulsastrix pulsastrix merged commit 3832486 into main Aug 27, 2024
10 checks passed
@pulsastrix pulsastrix deleted the chacha_poly branch August 27, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falko17 falko17 falko17 approved these changes

Assignees

@pulsastrix pulsastrix

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 0.5
Development

Successfully merging this pull request may close these issues.

COSE cryptographic algorithms - content encryption algorithms
3 participants
@pulsastrix @coveralls @falko17