Skip to content

refactor: apply review suggestions and some more lints

Sign in for the full log view
GitHub Actions / clippy failed Jul 14, 2024 in 2s

clippy

34 errors, 86 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 34
Warning 86
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 434 in src/token/cose/recipient/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
   --> src/token/cose/recipient/mod.rs:427:5
    |
427 | /     fn try_decrypt<B: CoseKeyDistributionCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
428 | |         &self,
429 | |         backend: &mut B,
430 | |         key_provider: &mut CKP,
...   |
433 | |         external_aad: &mut CAP,
434 | |     ) -> Result<Vec<CoseKey>, CoseCipherError<B::Error>>;
    | |_________________________________________________________^

Check warning on line 426 in src/token/cose/recipient/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
   --> src/token/cose/recipient/mod.rs:426:1
    |
426 | pub trait CoseRecipientExt {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 333 in src/token/cose/recipient/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
   --> src/token/cose/recipient/mod.rs:323:5
    |
323 | /     fn try_encrypt<B: CoseKeyDistributionCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
324 | |         self,
325 | |         backend: &mut B,
326 | |         key_provider: &mut CKP,
...   |
332 | |         external_aad: &mut CAP,
333 | |     ) -> Result<Self, CoseCipherError<B::Error>>;
    | |_________________________________________________^

Check warning on line 322 in src/token/cose/recipient/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
   --> src/token/cose/recipient/mod.rs:322:1
    |
322 | pub trait CoseRecipientBuilderExt: Sized {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 71 in src/token/cose/maced/mac0/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> src/token/cose/maced/mac0/mod.rs:65:5
   |
65 | /     fn try_verify<B: CoseMacCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
66 | |         &self,
67 | |         backend: &mut B,
68 | |         key_provider: &mut CKP,
69 | |         try_all_keys: bool,
70 | |         external_aad: &mut CAP,
71 | |     ) -> Result<(), CoseCipherError<B::Error>>;
   | |_______________________________________________^

Check warning on line 64 in src/token/cose/maced/mac0/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
  --> src/token/cose/maced/mac0/mod.rs:64:1
   |
64 | pub trait CoseMac0Ext {
   | ^^^^^^^^^^^^^^^^^^^^^

Check warning on line 24 in src/token/cose/maced/mac0/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> src/token/cose/maced/mac0/mod.rs:15:5
   |
15 | /     fn try_compute<B: CoseMacCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
16 | |         self,
17 | |         backend: &mut B,
18 | |         key_provider: &mut CKP,
...  |
23 | |         external_aad: &mut CAP,
24 | |     ) -> Result<Self, CoseCipherError<B::Error>>;
   | |_________________________________________________^

Check warning on line 14 in src/token/cose/maced/mac0/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
  --> src/token/cose/maced/mac0/mod.rs:14:1
   |
14 | pub trait CoseMac0BuilderExt: Sized {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 85 in src/token/cose/maced/mac/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> src/token/cose/maced/mac/mod.rs:75:5
   |
75 | /     fn try_verify_with_recipients<
76 | |         B: CoseKeyDistributionCipher + CoseMacCipher,
77 | |         CKP: CoseKeyProvider,
78 | |         CAP: CoseAadProvider,
...  |
84 | |         external_aad: &mut CAP,
85 | |     ) -> Result<(), CoseCipherError<B::Error>>;
   | |_______________________________________________^

Check warning on line 73 in src/token/cose/maced/mac/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> src/token/cose/maced/mac/mod.rs:67:5
   |
67 | /     fn try_verify<B: CoseMacCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
68 | |         &self,
69 | |         backend: &mut B,
70 | |         key_provider: &mut CKP,
71 | |         try_all_keys: bool,
72 | |         external_aad: &mut CAP,
73 | |     ) -> Result<(), CoseCipherError<B::Error>>;
   | |_______________________________________________^

Check warning on line 66 in src/token/cose/maced/mac/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
  --> src/token/cose/maced/mac/mod.rs:66:1
   |
66 | pub trait CoseMacExt {
   | ^^^^^^^^^^^^^^^^^^^^

Check warning on line 26 in src/token/cose/maced/mac/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> src/token/cose/maced/mac/mod.rs:17:5
   |
17 | /     fn try_compute<B: CoseMacCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
18 | |         self,
19 | |         backend: &mut B,
20 | |         key_provider: &mut CKP,
...  |
25 | |         external_aad: &mut CAP,
26 | |     ) -> Result<Self, CoseCipherError<B::Error>>;
   | |_________________________________________________^

Check warning on line 16 in src/token/cose/maced/mac/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
  --> src/token/cose/maced/mac/mod.rs:16:1
   |
16 | pub trait CoseMacBuilderExt: Sized {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 37 in src/token/cose/maced/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> src/token/cose/maced/mod.rs:31:5
   |
31 | /     fn verify_hmac(
32 | |         &mut self,
33 | |         algorithm: Algorithm,
34 | |         key: CoseSymmetricKey<'_, Self::Error>,
35 | |         tag: &[u8],
36 | |         data: &[u8],
37 | |     ) -> Result<(), CoseCipherError<Self::Error>>;
   | |__________________________________________________^

Check warning on line 29 in src/token/cose/maced/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> src/token/cose/maced/mod.rs:24:5
   |
24 | /     fn compute_hmac(
25 | |         &mut self,
26 | |         algorithm: Algorithm,
27 | |         key: CoseSymmetricKey<'_, Self::Error>,
28 | |         input: &[u8],
29 | |     ) -> Result<Vec<u8>, CoseCipherError<Self::Error>>;
   | |_______________________________________________________^

Check warning on line 138 in src/token/cose/signed/sign1/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
   --> src/token/cose/signed/sign1/mod.rs:131:5
    |
131 | /     fn try_verify_detached<B: CoseSignCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
132 | |         &self,
133 | |         backend: &mut B,
134 | |         key_provider: &mut CKP,
...   |
137 | |         aad: &mut CAP,
138 | |     ) -> Result<(), CoseCipherError<B::Error>>;
    | |_______________________________________________^

Check warning on line 129 in src/token/cose/signed/sign1/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
   --> src/token/cose/signed/sign1/mod.rs:123:5
    |
123 | /     fn try_verify<B: CoseSignCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
124 | |         &self,
125 | |         backend: &mut B,
126 | |         key_provider: &mut CKP,
127 | |         try_all_keys: bool,
128 | |         aad: &mut CAP,
129 | |     ) -> Result<(), CoseCipherError<B::Error>>;
    | |_______________________________________________^

Check warning on line 122 in src/token/cose/signed/sign1/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
   --> src/token/cose/signed/sign1/mod.rs:122:1
    |
122 | pub trait CoseSign1Ext {
    | ^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 99 in src/token/cose/signed/sign/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> src/token/cose/signed/sign/mod.rs:92:5
   |
92 | /     fn try_verify_detached<B: CoseSignCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
93 | |         &self,
94 | |         backend: &mut B,
95 | |         key_provider: &mut CKP,
...  |
98 | |         aad: &mut CAP,
99 | |     ) -> Result<(), CoseCipherError<B::Error>>;
   | |_______________________________________________^

Check warning on line 90 in src/token/cose/signed/sign/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> src/token/cose/signed/sign/mod.rs:84:5
   |
84 | /     fn try_verify<B: CoseSignCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
85 | |         &self,
86 | |         backend: &mut B,
87 | |         key_provider: &mut CKP,
88 | |         try_all_keys: bool,
89 | |         aad: &mut CAP,
90 | |     ) -> Result<(), CoseCipherError<B::Error>>;
   | |_______________________________________________^

Check warning on line 29 in src/token/cose/signed/sign/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> src/token/cose/signed/sign/mod.rs:22:5
   |
22 | /     fn try_add_sign_detached<B: CoseSignCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
23 | |         self,
24 | |         backend: &mut B,
25 | |         key_provider: &mut CKP,
...  |
28 | |         aad: &mut CAP,
29 | |     ) -> Result<Self, CoseCipherError<B::Error>>;
   | |_________________________________________________^

Check warning on line 20 in src/token/cose/signed/sign/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a method

warning: missing documentation for a method
  --> src/token/cose/signed/sign/mod.rs:14:5
   |
14 | /     fn try_add_sign<B: CoseSignCipher, CKP: CoseKeyProvider, CAP: CoseAadProvider>(
15 | |         self,
16 | |         backend: &mut B,
17 | |         key_provider: &mut CKP,
18 | |         sig: CoseSignature,
19 | |         aad: &mut CAP,
20 | |     ) -> Result<Self, CoseCipherError<B::Error>>;
   | |_________________________________________________^

Check warning on line 619 in src/token/cose/key.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a function

warning: missing documentation for a function
   --> src/token/cose/key.rs:615:1
    |
615 | / pub fn ensure_valid_ecdsa_key<'a, BE: Display>(
616 | |     algorithm: &Algorithm,
617 | |     parsed_key: CoseParsedKey<'a, BE>,
618 | |     key_should_be_private: bool,
619 | | ) -> Result<CoseEc2Key<'a, BE>, CoseCipherError<BE>> {
    | |____________________________________________________^

Check warning on line 429 in src/token/cose/key.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
   --> src/token/cose/key.rs:429:1
    |
429 | pub trait CoseAadProvider: BorrowMut<Self> {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 362 in src/token/cose/key.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

missing documentation for a trait

warning: missing documentation for a trait
   --> src/token/cose/key.rs:362:1
    |
362 | pub trait CoseKeyProvider {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^