Skip to content

Add support for AES-CCM #141

Add support for AES-CCM

Add support for AES-CCM #141

GitHub Actions / clippy completed Aug 22, 2024 in 0s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (4)

src/token/cose/encrypted/mod.rs|345 col 39| warning: this lifetime isn't used in the function definition
--> src/token/cose/encrypted/mod.rs:345:39
|
345 | fn determine_and_check_aes_params<'a, 'b, BE: Display>(
| ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
= note: #[warn(clippy::extra_unused_lifetimes)] on by default
src/token/cose/encrypted/mod.rs|354 col 9| warning: unnecessary closure used with bool::then
--> src/token/cose/encrypted/mod.rs:354:9
|
354 | (!v.iv.is_empty()).then(|| &v.iv)
| ^^^^^^^^^^^^^^^^^^^--------------
| |
| help: use then_some(..) instead: then_some(&v.iv)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
= note: #[warn(clippy::unnecessary_lazy_evaluations)] on by default
src/token/cose/encrypted/mod.rs|358 col 9| warning: unnecessary closure used with bool::then
--> src/token/cose/encrypted/mod.rs:358:9
|
358 | (!v.partial_iv.is_empty()).then(|| &v.partial_iv)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------
| |
| help: use then_some(..) instead: then_some(&v.partial_iv)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
src/token/cose/encrypted/mod.rs|395 col 80| warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/token/cose/encrypted/mod.rs:395:80
|
395 | message_iv[(expected_iv_len - partial_iv.len())..].copy_from_slice(&partial_iv);
| ^^^^^^^^^^^ help: change this to: partial_iv
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: #[warn(clippy::needless_borrow)] on by default

Filtered Findings (0)

Annotations

Check warning on line 345 in src/token/cose/encrypted/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] src/token/cose/encrypted/mod.rs#L345

warning: this lifetime isn't used in the function definition
   --> src/token/cose/encrypted/mod.rs:345:39
    |
345 | fn determine_and_check_aes_params<'a, 'b, BE: Display>(
    |                                       ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
    = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default
Raw output
src/token/cose/encrypted/mod.rs:345:39:w:warning: this lifetime isn't used in the function definition
   --> src/token/cose/encrypted/mod.rs:345:39
    |
345 | fn determine_and_check_aes_params<'a, 'b, BE: Display>(
    |                                       ^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
    = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default


__END__

Check warning on line 354 in src/token/cose/encrypted/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] src/token/cose/encrypted/mod.rs#L354

warning: unnecessary closure used with `bool::then`
   --> src/token/cose/encrypted/mod.rs:354:9
    |
354 |         (!v.iv.is_empty()).then(|| &v.iv)
    |         ^^^^^^^^^^^^^^^^^^^--------------
    |                            |
    |                            help: use `then_some(..)` instead: `then_some(&v.iv)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
    = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default
Raw output
src/token/cose/encrypted/mod.rs:354:9:w:warning: unnecessary closure used with `bool::then`
   --> src/token/cose/encrypted/mod.rs:354:9
    |
354 |         (!v.iv.is_empty()).then(|| &v.iv)
    |         ^^^^^^^^^^^^^^^^^^^--------------
    |                            |
    |                            help: use `then_some(..)` instead: `then_some(&v.iv)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
    = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default


__END__

Check warning on line 358 in src/token/cose/encrypted/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] src/token/cose/encrypted/mod.rs#L358

warning: unnecessary closure used with `bool::then`
   --> src/token/cose/encrypted/mod.rs:358:9
    |
358 |         (!v.partial_iv.is_empty()).then(|| &v.partial_iv)
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------
    |                                    |
    |                                    help: use `then_some(..)` instead: `then_some(&v.partial_iv)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations
Raw output
src/token/cose/encrypted/mod.rs:358:9:w:warning: unnecessary closure used with `bool::then`
   --> src/token/cose/encrypted/mod.rs:358:9
    |
358 |         (!v.partial_iv.is_empty()).then(|| &v.partial_iv)
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^----------------------
    |                                    |
    |                                    help: use `then_some(..)` instead: `then_some(&v.partial_iv)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations


__END__

Check warning on line 395 in src/token/cose/encrypted/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] src/token/cose/encrypted/mod.rs#L395

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/token/cose/encrypted/mod.rs:395:80
    |
395 |             message_iv[(expected_iv_len - partial_iv.len())..].copy_from_slice(&partial_iv);
    |                                                                                ^^^^^^^^^^^ help: change this to: `partial_iv`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default
Raw output
src/token/cose/encrypted/mod.rs:395:80:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/token/cose/encrypted/mod.rs:395:80
    |
395 |             message_iv[(expected_iv_len - partial_iv.len())..].copy_from_slice(&partial_iv);
    |                                                                                ^^^^^^^^^^^ help: change this to: `partial_iv`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default


__END__