Run nft tests in netns #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests that use nft command alter the system's nftables. By creating a fresh net namespace for each run, tests will not break system networking.
Luap99
reviewed
Mar 16, 2024
| (ip netns ls | grep -Fx "$NETNS" 2>/dev/null) || ip netns add "$NETNS" | ||
|
|
||
| nft --version; | ||
| nsexec cargo test --verbose -- --ignored |
There was a problem hiding this comment.
FYI, it should be much simpler to just use unshare -n cargo ... to create a new netns here, no need to manage any ip netns "names". You can also do unshare -rn as normal user (assuming unprivileged user namespaces are enabled, which is the default for most distros) so not even a need for sudo.
Because the netns is only tied to the process once the process exits the netns will be gone so you also can skip the clean-up logic as well
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that use nft command alter the system's nftables.
By creating a fresh net namespace for each run, tests will not break system networking.