Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix anonymous sets and XT #9

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix anonymous sets and XT #9

merged 3 commits into from
Sep 20, 2023

Conversation

jwhb
Copy link
Member

@jwhb jwhb commented Aug 12, 2023

This MR fixes the following problems:

  • Set item only support single elements
  • XT only be parsed as bool
  • Counter values are only u32.

@jwhb jwhb mentioned this pull request Aug 12, 2023
Closed
@jwhb jwhb linked an issue Aug 12, 2023 that may be closed by this pull request
Panic during deserialization in get_current_ruleset function #6
Closed
@jwhb jwhb added the bug Something isn't working label Aug 12, 2023
@jwhb jwhb merged commit 1b0c60b into main Sep 20, 2023
1 check passed
@jwhb jwhb deleted the anonymous-sets branch September 20, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKRhb JKRhb JKRhb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic during deserialization in get_current_ruleset function
2 participants
@jwhb @JKRhb