fix: コミットデータが0の時の表示を追加 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODOコメントは見つかりませんでした。 |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
app/recap/components/graph/languages.tsx:101
- Using template literals inside JSX can lead to unexpected results. Consider using JSX expressions instead, like this: {
あなたが最も使用した言語は <b>${limitedData[0].language}</b> です。}
: `あなたが最も使用した言語は <b>${limitedData[0].language}</b> です。`
| @@ -61,7 +61,7 @@ export const OverView: FC<Props> = async ({ data }) => { | |||
| </CardHeader> | |||
| <CardContent className="pr-24 space-y-1"> | |||
| <div className="text-sm text-muted-foreground font-bold italic truncate"> | |||
| "{data.userProfile.bio}" | |||
| {data.userProfile.bio && "{data.userProfile.bio}"} | |||
There was a problem hiding this comment.
The string interpolation is incorrect. It should be {data.userProfile.bio} instead of "{data.userProfile.bio}".
Suggested change
| {data.userProfile.bio && "{data.userProfile.bio}"} | |
| {data.userProfile.bio && `${data.userProfile.bio}`} |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Deploying dev-recap with
|
| Latest commit: |
b95750a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b6d8e951.dev-recap.pages.dev |
| Branch Preview URL: | https://fix-no-data.dev-recap.pages.dev |
|
@github-actions approve me |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
変更内容
確認したこと
スクリーンショット
補足事項
PR 時のセルフチェック