Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logic] Cheats | APU enhancement | BSRAM save/load - PAL - 1:1/8:7 aspect ratio support #88

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

fjpolo
Copy link
Contributor

@fjpolo fjpolo commented Jul 8, 2024

Add support for BSRAM save/load ❌ (WIP)
Add PAL support ✔
Add 1:1/8:7 aspect ratio support ✔

[APU]
Improved R2A03 APU’s triangle wave and made its mixer linear ✔
Improved mapper VRC6’s sawtooth wave. Mixer is already linear ✔

[VRC6]
Added mapper. Tested on Castlevania III (Japan). Needs more testing ✔

[Mapper4/69]
Disabled APU Enhancement because volume levels saturate ✔

[Cheats]

  • Add support for 4 cheats ✔

Firmware

fjpolo added 30 commits June 5, 2024 20:06
- Remove unnecessary files
- Noise Channel needs to be shifted left for linear mixing
- Fix VRC6 Triangle Channel
@fjpolo fjpolo changed the title BSRAM save/load - PAL - 1:1/8:7 aspect ratio support APU enhancement | BSRAM save/load - PAL - 1:1/8:7 aspect ratio support Jul 8, 2024
@fjpolo fjpolo mentioned this pull request Jul 8, 2024
@fjpolo fjpolo changed the title APU enhancement | BSRAM save/load - PAL - 1:1/8:7 aspect ratio support Cheats | APU enhancement | BSRAM save/load - PAL - 1:1/8:7 aspect ratio support Jul 8, 2024
- Add register with flags

[Timer0]
- Add Timer0 register for its load value, counter and add flag to Timer Interrupt Register
@fjpolo
Copy link
Contributor Author

fjpolo commented Jul 17, 2024

RV not loading OSD Key is fixed. Only WIP is BSRAM save/load for NES

@fjpolo fjpolo changed the title Cheats | APU enhancement | BSRAM save/load - PAL - 1:1/8:7 aspect ratio support [Logic] Cheats | APU enhancement | BSRAM save/load - PAL - 1:1/8:7 aspect ratio support Jul 17, 2024
- Conceptual error: RV writes to RAM through iosys (that's where I backep up 0x6000 to 0x8000) but in reality, we want to backup what the NES writes directly to RAM
- Remove iosys backup into BRAM
- If mapper sturates, then still use enhanced triangle but use normal mixer
- Fix copy-paste mistake
- Fix copy-paste error
- No need for tri_lut_enhanced_5b[] to be 7b wide, 6b is enoughnsince MAX = 0x3C
- Normal mixer + enhanced triangle wave: no need for shifting bits
- Fix bad merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant