Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract PDUs from Servers views #304

Merged
merged 13 commits into from
Feb 5, 2025
Merged

Extract PDUs from Servers views #304

merged 13 commits into from
Feb 5, 2025

Conversation

B-Rass
Copy link
Collaborator

@B-Rass B-Rass commented Dec 18, 2024

No description provided.

@B-Rass B-Rass self-assigned this Dec 18, 2024
@B-Rass B-Rass changed the title Extract PDUs from Servers views + add PDUs new attributes Extract PDUs from Servers views Jan 17, 2025
@B-Rass B-Rass force-pushed the 330721-extract-pdu-from-server-and-add-them-attributes branch 3 times, most recently from a8ed1bc to bcfd0ed Compare January 22, 2025 17:03
@B-Rass B-Rass marked this pull request as ready for review January 22, 2025 17:04
@B-Rass B-Rass force-pushed the 330721-extract-pdu-from-server-and-add-them-attributes branch from bcfd0ed to 1d90bb5 Compare January 22, 2025 17:06
@B-Rass B-Rass force-pushed the 330721-extract-pdu-from-server-and-add-them-attributes branch from a8ba393 to 7509ecb Compare January 29, 2025 17:19
@B-Rass B-Rass marked this pull request as draft January 29, 2025 17:19
@B-Rass B-Rass force-pushed the 330721-extract-pdu-from-server-and-add-them-attributes branch from 7509ecb to ee65fd7 Compare January 30, 2025 16:25
@B-Rass B-Rass marked this pull request as ready for review January 30, 2025 16:25
nicolas-brousse
nicolas-brousse requested changes Feb 5, 2025
View reviewed changes
spec/requests/servers_request_spec.rb Outdated Show resolved Hide resolved
spec/models/server_spec.rb Outdated Show resolved Hide resolved
app/views/servers/_form.html.erb Outdated Show resolved Hide resolved
app/controllers/servers_controller.rb Outdated Show resolved Hide resolved
app/views/servers/show.html.erb Outdated Show resolved Hide resolved
@B-Rass B-Rass force-pushed the 330721-extract-pdu-from-server-and-add-them-attributes branch from ee65fd7 to 18940aa Compare February 5, 2025 15:02
@B-Rass B-Rass force-pushed the 330721-extract-pdu-from-server-and-add-them-attributes branch from 18940aa to fd07ad1 Compare February 5, 2025 16:42
nicolas-brousse
nicolas-brousse requested changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@nicolas-brousse nicolas-brousse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last change to do and we be able to merge this :)

app/controllers/power_distribution_units_controller.rb Outdated Show resolved Hide resolved
@B-Rass @nicolas-brousse
Update app/controllers/power_distribution_units_controller.rb
572c796 
Co-authored-by: Nicolas Brousse <nicolas-brousse@users.noreply.github.com>
@nicolas-brousse nicolas-brousse merged commit 6e7108a into nanego:master Feb 5, 2025
1 check passed
@nicolas-brousse nicolas-brousse deleted the 330721-extract-pdu-from-server-and-add-them-attributes branch February 5, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-brousse nicolas-brousse nicolas-brousse approved these changes

Assignees

@B-Rass B-Rass

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@B-Rass @nicolas-brousse