Glitch tweak #1867
Merged
Glitch tweak #1867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a CHANGELOG entry. |
abhisrkckl
reviewed
Dec 5, 2024
src/pint/models/glitch.py
Outdated
Comment on lines
148
to
154
| if not hasattr(self, param + "%d" % idx): | ||
| if not hasattr(self, param + str(idx)): | ||
| param0 = getattr(self, f"{param}1") | ||
| self.add_param(param0.new_param(idx)) | ||
| getattr(self, param + "%d" % idx).value = 0.0 | ||
| getattr(self, param + str(idx)).value = 0.0 | ||
| self.register_deriv_funcs( | ||
| getattr(self, f"d_phase_d_{param[:-1]}"), param + "%d" % idx | ||
| getattr(self, f"d_phase_d_{param[:-1]}"), param + str(idx) | ||
| ) |
There was a problem hiding this comment.
It will be better to use fstring instead of the + operator here since that is the style we had decided to prefer.
I'm never sure where to draw the line but... is it worth noting relatively minor code cleanup in the CHANGELOG? It's not something, imo, that users of new versions really need to be aware of. |
|
I think it's good for posterity, in case someone wonders in the future when/how/why some change was made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bunch of nearly-duplicate code in the Glitch derivatives, so I pushed that into the "deriv_prep" function. Otherwise, I switched to f-strings, cleaned up the math and syntax in a few places, and added some missing tests for sanity checks on models.
(E.g., the code attempts to test for a missing GLEP, but there was no test coverage for that. The code only checked for whether or not a GLEP was present, but it always is! It's value is set to None, though, so the code now checks for that and the test covers it.