Url accessors #1938
Merged
Url accessors #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the separation of nni_url and nng_url.
This provides safety by ensuring that applications do not depend on the size or layout of nng_url itself.
The inline parsing will be used internally to avoid some allocations.
We moved some of the tests out of the older Convey framework into the NUTS framework.
While TCP and UDP port numbers are 16-bits, ZT uses a larger (24-bit) port number.
This is a step on cleaning up our logic around NNG_OPT_URL.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1938 +/- ##
==========================================
- Coverage 81.04% 80.97% -0.08%
==========================================
Files 94 94
Lines 23951 24015 +64
Branches 3187 3192 +5
==========================================
+ Hits 19412 19445 +33
- Misses 4464 4497 +33
+ Partials 75 73 -2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This is intended to replace NNG_OPT_URL.
This is done so that we can provide transport specific logic for URL parsing later (we're going to want this for ZeroTier for example.)
gdamore
force-pushed
the
url-accessors
branch
from
e6696ed to
cef6e70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #
Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.