Gdamore/more opt url #1939
Merged
Gdamore/more opt url #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to start ripping out support for it. The alternative functions should be used instead.
This permits removal of an extra bit of clean up.
This means that most URLs can now be used without any allocations needed. It eliminates some failure paths.
The idea is to allow nng_dialer_create_url() and such to avoid having to reparse a URL that we already have.
This allows a URL object to be used for dialing, which may be easier than using a string if you already have the URL object.
gdamore
force-pushed
the
gdamore/more-opt-url
branch
from
663bd78 to
6dfdcac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1939 +/- ##
==========================================
- Coverage 80.97% 80.86% -0.11%
==========================================
Files 94 94
Lines 24015 24072 +57
Branches 3192 3204 +12
==========================================
+ Hits 19445 19467 +22
- Misses 4497 4531 +34
- Partials 73 74 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #
Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.