Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aio defer #1993

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Aio defer #1993

merged 1 commit into from
Dec 23, 2024

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Dec 16, 2024

fixes #

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 77.41935% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.22%. Comparing base (013bb69) to head (c8ce57d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/aio.c 70.21% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1993      +/-   ##
==========================================
+ Coverage   82.07%   82.22%   +0.14%     
==========================================
  Files          95       95              
  Lines       23891    23918      +27     
  Branches     3137     3142       +5     
==========================================
+ Hits        19608    19666      +58     
+ Misses       4211     4178      -33     
- Partials       72       74       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This will replace nni_aio_schedule, and it includes finishing the
task if needed.  It does so without dropping the lock and so is
more efficient and race free.

This includes some conversion of some subsystems to it.
@gdamore gdamore merged commit c8ce57d into main Dec 23, 2024
35 of 36 checks passed
@gdamore gdamore deleted the aio-defer branch December 23, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant