Remove mention of outdated plugin from quick start #908
Conversation
github-actions
bot
added
the
documentation
|
? not sure I understand the fail. I don't see anything useful in the circleci output |
|
I don't have time right now, but here's my process: |
|
Yeah I did but that's irrelevant to my PR, right?I assume its about the mermaid's but I dont get it |
|
sphinxcontrib-mermaid had a new release with breaking changes, and we don't pin it. So you need to change this line to read
and the build works (tested locally) You can see the config value here: https://sphinxcontrib-mermaid-demo.readthedocs.io/en/stable/ (old version) and here https://sphinxcontrib-mermaid-demo.readthedocs.io/en/latest/#mermaid-include-elk (new version) |
|
We do have constraints though, so if this is due to a package update, then this suggests they aren't working properly. |
|
Well, it looks like we should be using the constraints: Line 69 in 1f9759b which do pin sphinxcontrib-mermaid https://github.com/napari/napari/blob/326d0144b22b7808cd16dfeb49c48590d94869d9/resources/constraints/constraints_py3.12_docs.txt#L710 But this doesn't take effect in circleci, so sphinxcontrib-mermaid which is not pinned here https://github.com/napari/napari/blob/326d0144b22b7808cd16dfeb49c48590d94869d9/pyproject.toml#L197 is installed to the latest version 😬 Maybe uv doesn't take in to account the PIP_CONSTRAINTS argument? https://app.circleci.com/pipelines/github/napari/docs/1752/workflows/adef5c30-e6be-41c9-9701-1d9caa83e8c2/jobs/1753?invite=true#step-106-3450_31 |
|
Yeah it's something like that, but not quite because here's the GA run which has the older version, so presumably from constraints and it's also uv |
|
If you look at the working action it uses: PR Inc. |
# References and relevant issues Circle CI docs not using constraints: #908 (comment) # Description Looks like UV isn't using the PIP env var. This uses the UV one.
|
@psobolewskiPhD and @melissawm true 🧙s |
4 participants
References and relevant issues
Follow-up to #881
Description
While reading through the new quickstart, I noticed this mention of an un-maintained plugin. For a while, the plugin did not work, but I do think it does appear to be fixed now MouseLand/cellpose-napari#51 (comment)
I propose we remove this very small mention.
We can consider adding back plugins once we have our review system in place. My preference would be for us to make a "starter plugins" guide, rather than a short quip (that's hard to notice because of its placement!) in this quick start. There already is good detail here pointing people towards the hub :)