Skip to content

Commit

Permalink
Revert "xfail to_arrow tests for cuDF"
Browse files Browse the repository at this point in the history
This reverts commit d695efd.
  • Loading branch information
LiamConnors committed Sep 8, 2024
1 parent d695efd commit 58c1b23
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
2 changes: 0 additions & 2 deletions tests/frame/to_arrow_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ def test_to_arrow(request: Any, constructor_eager: Any) -> None:
if "pandas" in str(constructor_eager) and parse_version(pd.__version__) < (1, 0, 0):
# pyarrow requires pandas>=1.0.0
request.applymarker(pytest.mark.xfail)
if "cudf" in str(constructor_eager):
request.applymarker(pytest.mark.xfail)

data = {"a": [1, 3, 2], "b": [4, 4, 6], "z": [7.1, 8, 9]}
df_raw = constructor_eager(data)
Expand Down
11 changes: 3 additions & 8 deletions tests/series_only/to_arrow_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@
import narwhals.stable.v1 as nw


def test_to_arrow(constructor_eager: Any, request: Any) -> None:
if "cudf" in str(constructor_eager):
request.applymarker(pytest.mark.xfail)

def test_to_arrow(constructor_eager: Any) -> None:
data = [1, 2, 3]
result = nw.from_native(constructor_eager({"a": data}), eager_only=True)[
"a"
Expand All @@ -23,10 +20,8 @@ def test_to_arrow(constructor_eager: Any, request: Any) -> None:


def test_to_arrow_with_nulls(constructor_eager: Any, request: Any) -> None:
if (
"pandas_constructor" in str(constructor_eager)
or "modin_constructor" in str(constructor_eager)
or "cudf" in str(constructor_eager)
if "pandas_constructor" in str(constructor_eager) or "modin_constructor" in str(
constructor_eager
):
request.applymarker(pytest.mark.xfail)

Expand Down

0 comments on commit 58c1b23

Please sign in to comment.