Skip to content

Commit

Permalink
test: catch some cudf failures (#1735)
Browse files Browse the repository at this point in the history
  • Loading branch information
MarcoGorelli authored Jan 6, 2025
1 parent 8c9525a commit e56f91d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ omit = [
exclude_also = [
"if sys.version_info() <",
"if .*implementation is Implementation.CUDF",
"if .*implementation.is_cudf",
'request.applymarker\(pytest.mark.xfail',
'backend_version <',
'if "cudf" in str\(constructor'
Expand Down
3 changes: 3 additions & 0 deletions tests/expr_and_series/clip_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ def test_clip_expr_expressified(
) -> None:
if "modin_pyarrow" in str(constructor):
request.applymarker(pytest.mark.xfail)
if "cudf" in str(constructor):
# https://github.com/rapidsai/cudf/issues/17682
request.applymarker(pytest.mark.xfail)

data = {"a": [1, 2, 3, -4, 5], "lb": [3, 2, 1, 1, 1], "ub": [4, 4, 2, 2, 2]}
df = nw.from_native(constructor(data))
Expand Down
6 changes: 5 additions & 1 deletion tests/expr_and_series/lit_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,8 @@ def test_date_lit(constructor: Constructor, request: pytest.FixtureRequest) -> N
request.applymarker(pytest.mark.xfail)
df = nw.from_native(constructor({"a": [1]}))
result = df.with_columns(nw.lit(date(2020, 1, 1), dtype=nw.Date)).collect_schema()
assert result == {"a": nw.Int64, "literal": nw.Date}
if df.implementation.is_cudf():
# cudf has no date dtype
assert result == {"a": nw.Int64, "literal": nw.Datetime}
else:
assert result == {"a": nw.Int64, "literal": nw.Date}

0 comments on commit e56f91d

Please sign in to comment.