feat: add missing dunder methods in SparkLikeExpr and SparkLikeNamespace.lit
#1708
Conversation
| @@ -145,32 +145,136 @@ def func(df: SparkLikeLazyFrame) -> list[Column]: | |||
|
|
|||
| def __add__(self, other: SparkLikeExpr) -> Self: | |||
| return self._from_call( | |||
| lambda _input, other: _input + other, | |||
| lambda _input, other: _input.__add__(other), | |||
There was a problem hiding this comment.
changed to use the Column dunder methods as we do in Dask
|
thanks @EdAbati ! we recently updated the |
|
Oh interesting ! I will make a separate PR that we can merge before this one |
|
we can also remove the |
EdAbati
changed the title
SparkLikeExprSparkLikeExpr and SparkLikeNamespace.lit
| if dtype is not None: | ||
| msg = "todo" |
There was a problem hiding this comment.
We need narwhals_to_native_dtype for Spark.
Sitting on my laptop there is an oldish branch with cast that has narwhals_to_native_dtype.
Can this be a follow up?
|
Hey @MarcoGorelli I had a look at adding Would it be ok to have it as a follow up? |
There was a problem hiding this comment.
yup, sure! thanks @EdAbati , merging then so we can unblock the other pr
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below