-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement partial "lazy" support for DuckDB (even with this PR, DuckDB support is work-in-progress!) #1725
Merged
MarcoGorelli
merged 116 commits into
narwhals-dev:main
from
MarcoGorelli:duckdb-relational
Jan 6, 2025
Merged
Changes from 109 commits
Commits
Show all changes
116 commits
Select commit
Hold shift + click to select a range
fc950bd
duckdb with_columns
MarcoGorelli d06a45a
polars 1.18 compat
MarcoGorelli 9190c5c
wip
MarcoGorelli 21a3a9f
more wip
MarcoGorelli da43745
wip
MarcoGorelli f9e27ce
wip
MarcoGorelli 9699671
simplify
MarcoGorelli 2130494
simplify
MarcoGorelli a20236c
fix
MarcoGorelli f515e66
Merge remote-tracking branch 'upstream-token/main' into duckdb-relatiβ¦
MarcoGorelli d33c82a
implement sort
MarcoGorelli b781550
getting there!
MarcoGorelli 8fb44dc
wip
MarcoGorelli 3d27066
wip
MarcoGorelli 105982a
wip
MarcoGorelli 92593c1
wip
MarcoGorelli 4be7ae5
simplify
MarcoGorelli 9dab9a5
with renaming
MarcoGorelli 3ecaf9b
groupby tests passing
MarcoGorelli 7f8c82d
wip
MarcoGorelli 2a6fa99
hey we can do all of q1!
MarcoGorelli ac5e827
inner join
MarcoGorelli dc1392e
wip
MarcoGorelli 763583e
wip
MarcoGorelli f0229f9
wip
MarcoGorelli 62743b4
max horizontal and min horizontal working!!!
MarcoGorelli 7e62298
got clip too!
MarcoGorelli b27a60a
str.startswith
MarcoGorelli 9570e1b
is_between
MarcoGorelli 5e87db1
add unique
MarcoGorelli 0a8f890
refactor
MarcoGorelli f4b7c9f
lint
MarcoGorelli f064bf7
fixup
MarcoGorelli 3c2e409
wip join
MarcoGorelli 34af8f4
wip
MarcoGorelli 876c247
lets do this
MarcoGorelli 88f851e
add slice for duckdb
raisadz 83cdfcf
simplify slice
raisadz f811661
Merge pull request #2 from raisadz/duckdb-relational
MarcoGorelli f63e3b7
Merge branch 'duckdb-relational' of github.com:MarcoGorelli/narwhals β¦
MarcoGorelli fbd3a10
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli 1955f6b
concat
MarcoGorelli 4b9ae7b
concat
MarcoGorelli c4e61c0
q7 runs!
MarcoGorelli f261b64
q9 runs
MarcoGorelli 0c0df97
contains test
MarcoGorelli 4c23549
add round
MarcoGorelli 7d149d8
invert
MarcoGorelli 1e285fc
unique
MarcoGorelli 6b6c3ef
expressify is_between
MarcoGorelli e4f2dfc
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli fbb4ce2
feat: add `to_lowercase` and `to_uppercase` to duckdb
raisadz a8d303d
Merge pull request #3 from raisadz/duckdb-relational
MarcoGorelli cf8bd98
add `strip_chars` to duckdb
raisadz 2139ad0
Merge remote-tracking branch 'marcogorelli/duckdb-relational' into duβ¦
raisadz b1b9230
add replace_all
raisadz e3bca42
strip all white spaces
raisadz b122af7
Merge pull request #4 from raisadz/duckdb-relational-strip-chars
MarcoGorelli 42ce7b2
Merge branch 'duckdb-relational' of github.com:MarcoGorelli/narwhals β¦
MarcoGorelli 81a9241
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli 07a5232
add notimplemented for `replace` and literal is only True for `replacβ¦
raisadz bd262d0
Merge remote-tracking branch 'marcogorelli/duckdb-relational' into duβ¦
raisadz fc5303f
som exfails
MarcoGorelli 364ae0d
raise notimplemetederror instead of typeerror
raisadz a34f936
unique
MarcoGorelli 2abf875
wip
MarcoGorelli ca1c643
Merge pull request #5 from raisadz/duckdb-relational-replace-all
MarcoGorelli 899eb89
yay xfail less
MarcoGorelli d97270d
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli e80c568
duckdb unique
MarcoGorelli c45767c
sort out unique
MarcoGorelli 00a74dd
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli bbace71
fixup duckdb_test
MarcoGorelli 6e9c598
datetime attributes
MarcoGorelli 0af5293
var std working
MarcoGorelli 16b2627
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli 9994ed1
wip
MarcoGorelli 431ab4f
wip
MarcoGorelli 2a6a9f5
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli 0e30dd8
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli c48aa78
wip
MarcoGorelli 4aab7ca
fixup scalars
MarcoGorelli 1bdc16a
keep going
MarcoGorelli ef61772
reductions test
MarcoGorelli be617a3
expressified clip
MarcoGorelli 69d0255
go further
MarcoGorelli 30df0b1
all expr tests passing
MarcoGorelli 0a8fcc0
more tests
MarcoGorelli 9bb16c6
more
MarcoGorelli 88d228a
get all tests green :broccoli:
MarcoGorelli 2c73c9a
get all tests green :broccoli:
MarcoGorelli feca043
document
MarcoGorelli 5ca717a
update docs
MarcoGorelli 60c1897
fixup conftest
MarcoGorelli b57c7f8
fixup conftest
MarcoGorelli d1fad9f
importorskip
MarcoGorelli a25f07d
fix docs
MarcoGorelli 9c8fcfd
fixup test
MarcoGorelli fbccfc8
docs
MarcoGorelli f36dece
remove maintain_order for duckdb
MarcoGorelli eba33b7
fixup docs and tpch
MarcoGorelli e749a98
unique test
MarcoGorelli 89e58d5
coverage
MarcoGorelli bf373af
coverage
MarcoGorelli adb3db8
coverage
MarcoGorelli a2578d8
dask
MarcoGorelli a8cfa91
cov
MarcoGorelli 8b6ef7c
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli 5c70cc6
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli 2c28b6f
reduce diff
MarcoGorelli f3733d2
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli 32016e4
simplify
MarcoGorelli d8c8919
catch missing pyarrow in collect
MarcoGorelli 60979a4
simplify
MarcoGorelli 5342308
Merge remote-tracking branch 'upstream/main' into duckdb-relational
MarcoGorelli d8247ac
fix returns_scalar in abs
MarcoGorelli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we create a
check_columns_exist
function innarwhals.utils
so we can reuse everywhere else? :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sure!