Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update api-completeness with duckdb #1740

Merged
merged 3 commits into from
Jan 6, 2025
Merged

docs: update api-completeness with duckdb #1740

merged 3 commits into from
Jan 6, 2025

Conversation

AlessandroMiola
Copy link
Contributor

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Updates api-completeness with duckdb reference

@AlessandroMiola AlessandroMiola marked this pull request as ready for review January 6, 2025 17:25
MarcoGorelli
MarcoGorelli approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @AlessandroMiola , looks good!

and it's greener than i was expecting 😄 🥦

@MarcoGorelli MarcoGorelli added the documentation Improvements or additions to documentation label Jan 6, 2025
@MarcoGorelli MarcoGorelli merged commit 17546f2 into narwhals-dev:main Jan 6, 2025
23 checks passed
@AlessandroMiola AlessandroMiola deleted the update-api-completeness-with-duckdb branch January 6, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlessandroMiola @MarcoGorelli