Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Increased width for content #1769

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

marvinl803
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • [x ] πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • [x ] Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

I have added custom css which targets the content of the grid and it allows it to fully stretch the content area. If there are any issues, or corrections needed let me know.

Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton @marvinl803 !
If it would be possible to keep some (tiny) margin on the left I think it could be a bit nicer! If not I am happy to ship it as is πŸš€

@marvinl803
Copy link
Contributor Author

marvinl803 commented Jan 9, 2025

Thanks a ton @marvinl803 ! If it would be possible to keep some (tiny) margin on the left I think it could be a bit nicer! If not I am happy to ship it as is πŸš€

For sure, no problem @FBruzzesi ! I’ve added a bit of left margin, let me know if this works for you or if you'd like any further adjustments.

Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thank you @marvinl803

NarwhalChubbiwhalGIF

@FBruzzesi FBruzzesi merged commit ab21e72 into narwhals-dev:main Jan 9, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Increase documentation page width
2 participants