Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duckdb join was failing if column names contained spaces #1775

Merged
merged 3 commits into from
Jan 9, 2025
Merged

fix: duckdb join was failing if column names contained spaces #1775

merged 3 commits into from
Jan 9, 2025

Conversation

MarcoGorelli
Copy link
Member

@MarcoGorelli MarcoGorelli commented Jan 9, 2025 •
edited
Loading

closes #1774

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@MarcoGorelli MarcoGorelli changed the title Duckdb sanitise fix: duckdb join was failing if column names contained spaces Jan 9, 2025
@MarcoGorelli MarcoGorelli marked this pull request as ready for review January 9, 2025 15:13
FBruzzesi
FBruzzesi approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so afraid that now so many tests will have column names with spaces 😂

But also, time for some duck gifs!

MallarDuckGifGIF

@MarcoGorelli MarcoGorelli merged commit 9abe7d2 into narwhals-dev:main Jan 9, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FBruzzesi FBruzzesi FBruzzesi approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: joins in duckdb fail if names contain spaces
2 participants
@MarcoGorelli @FBruzzesi