fix root names in pyspark reduction with nw.all() #1787
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -102,7 +102,9 @@ def func(df: SparkLikeLazyFrame) -> list[Column]: | |||
| for _input in inputs: | |||
| input_col_name = get_column_name(df, _input) | |||
| column_result = call(_input, **_kwargs) | |||
| if not returns_scalar: | |||
| if not returns_scalar or ( | |||
| (self._depth == 0) and (self._function_name == "all") | |||
There was a problem hiding this comment.
thanks for looking into this!
I think this might be too specific and that we'll need a more generic solution - will look into it and let you know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
nw.all()#1780Checklist
If you have comments or can explain your changes, please do so below
Checking if the parent expression is the root and if that expression is "all" to also alias the result seems to alleviate this problem in this particular test.
This may need to be revisited when the
.namenamespace is created for pyspark as I am unsure whether or not this approach play nicely with multi columnar renaming functions likeprefix,suffixormap.