Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate maintain_order in Expr.unique and LazyFrame.tail (but keep around in stable.v1) #1839

Merged
merged 12 commits into from
Jan 20, 2025

Conversation

MarcoGorelli
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@MarcoGorelli MarcoGorelli force-pushed the unique-maintain-order branch from 0859b6e to cad9006 Compare January 20, 2025 10:39
@MarcoGorelli MarcoGorelli added the enhancement New feature or request label Jan 20, 2025
@MarcoGorelli MarcoGorelli changed the title feat: deprecate maintain_order in Expr.unique feat: deprecate maintain_order in Expr.unique (but keep around in stable.v1) Jan 20, 2025
@MarcoGorelli MarcoGorelli marked this pull request as ready for review January 20, 2025 10:45
@MarcoGorelli MarcoGorelli changed the title feat: deprecate maintain_order in Expr.unique (but keep around in stable.v1) feat: deprecate maintain_order in Expr.unique and LazyFrame.tail (but keep around in stable.v1) Jan 20, 2025
@MarcoGorelli MarcoGorelli merged commit 7a9560b into narwhals-dev:main Jan 20, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant