feat: pyspark and duckdb selectors #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Jan 22, 2025
| @@ -96,7 +88,7 @@ def test_set_ops( | |||
| expected: list[str], | |||
| request: pytest.FixtureRequest, | |||
| ) -> None: | |||
| if ("pyspark" in str(constructor)) or "duckdb" in str(constructor): | |||
| if "duckdb" in str(constructor) and not expected: | |||
There was a problem hiding this comment.
To figure this out due to:
# TODO(marco): return empty relation with 0 columns?
return self._from_native_frame(self._native_frame.limit(0))took me some sanity 😂
I tried in different ways to create an empty table but duckdb doesn't really like that. Maybe we might just raise an error?
FBruzzesi
added
enhancement
| dtypes = import_dtypes_module(self._version) | ||
| return self.by_dtype( | ||
| [ | ||
| dtypes.Int64, |
There was a problem hiding this comment.
do we need dtypes.Int128 in here too now?
There was a problem hiding this comment.
Should it be added everywhere?
|
nice, thanks - i'm just in the middle of a big refactor, so i'll finish that, then i'll update these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Checklist
If you have comments or can explain your changes, please do so below