Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename ewm and rolling min_periods to min_samples for polars 1.21 compatibility #1864

Merged
merged 3 commits into from
Jan 25, 2025
Merged

fix: rename ewm and rolling min_periods to min_samples for polars 1.21 compatibility #1864

merged 3 commits into from
Jan 25, 2025

Conversation

FBruzzesi
Copy link
Member

@FBruzzesi FBruzzesi commented Jan 25, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

@FBruzzesi FBruzzesi marked this pull request as ready for review January 25, 2025 09:47
MarcoGorelli
MarcoGorelli reviewed Jan 25, 2025
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

narwhals/_arrow/series.py Show resolved Hide resolved
MarcoGorelli
MarcoGorelli approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @FBruzzesi

@MarcoGorelli MarcoGorelli merged commit aceec01 into main Jan 25, 2025
22 of 24 checks passed
@MarcoGorelli MarcoGorelli deleted the fix/min_periods-to-min_samples-renaming branch January 25, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FBruzzesi @MarcoGorelli