Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more queries of tpch #898

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

luke396
Copy link
Member

@luke396 luke396 commented Sep 3, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

I've adopted a more generic coding approach, which may be easier to modify and expand now.

If this is acceptable, I plan to refactor all existing execute codes accordingly; if not, I'll revert the changes to the original state.

@github-actions github-actions bot added the enhancement New feature or request label Sep 3, 2024
@luke396 luke396 requested a review from MarcoGorelli September 4, 2024 11:26
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is amazing! you're amazing! thanks so much @luke396 !

@MarcoGorelli MarcoGorelli merged commit 69da133 into narwhals-dev:main Sep 4, 2024
21 checks passed
@luke396 luke396 deleted the add-more-query branch September 5, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants