feat: Add q12, q13, q14, q16, q22 #910
Conversation
tpch/queries/q16.py
Outdated
| .join(supplier, left_on="ps_suppkey", right_on="s_suppkey", how="left") | ||
| .filter(nw.col("ps_suppkey_right").is_null()) | ||
| .group_by("p_brand", "p_type", "p_size") | ||
| .agg(nw.col("ps_suppkey").unique().len().alias("supplier_cnt")) |
There was a problem hiding this comment.
unique().len() changed from n_unique()
Because AttributeError: 'SeriesGroupBy' object has no attribute 'n_unique'.
There was a problem hiding this comment.
I made an attempt in #917, I don't have time to test against the queries right now though 🙈
|
All works well, except q16 and q22 raise |
tpch/queries/q16.py
Outdated
| .join(supplier, left_on="ps_suppkey", right_on="s_suppkey", how="left") | ||
| .filter(nw.col("ps_suppkey_right").is_null()) | ||
| .group_by("p_brand", "p_type", "p_size") | ||
| .agg(nw.col("ps_suppkey").unique().len().alias("supplier_cnt")) |
|
As observed in #918, we have remove (Not sure if this is appreciated.) |
There was a problem hiding this comment.
awesome, thanks so much @luke396 !
yeah I cut down a bit on what gets executed to save some time (as you can intuit, I'm a bit impatient with waiting for things to run 😄 )
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.
Not done for now, some fix needed.