Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add luxon date checks #5

Closed
wants to merge 1 commit into from

Conversation

selamanse
Copy link

Solves #2

@selamanse
Copy link
Author

selamanse commented Oct 31, 2021

Still needs some test coverage

@narze how exactly are the unit tests executed? do i need to run this with wrangler?

If you want me to add test coverage in this pr I need to move SUPABASE_KEY to some sort of env (or I don't know how it works)

@selamanse
Copy link
Author

@narze can you please add the hacktoberfest-accepted label to this PR? I will continue working on this tomorrow.

@narze
Copy link
Owner

narze commented Nov 1, 2021

Sure thing!
For the ENV I already tried dotenv but it does not work for me as well, I never used Cloudflare Pages before so I'm not sure what's the best way to setup the ENV files.

@narze
Copy link
Owner

narze commented Nov 2, 2021

Closing this since https://github.com/narze/poppoll does not call this endpoint anymore.

@narze narze closed this Nov 2, 2021
@selamanse
Copy link
Author

Ok, Do you still Need help with those env files @narze?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants