Clean up comments and formatting #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
troyraen
commented
Dec 5, 2024
troyraen
commented
- Remove unused code
- Manually wrap extremely long code lines
- Change notebook kernelspec to new Fornax defaults
- Update notebook runtime statement
troyraen
commented
Dec 5, 2024
Comment on lines
-84
to
+85
| As of 2024 August, this notebook takes ~330s to run to completion on Fornax using the 'Astrophysics | ||
| Default Image' and the 'Large' server with 16GB RAM/ 4CPU. | ||
| As of 2024 August, this notebook takes about 3 minutes to run to completion on Fornax using | ||
| Server Type: 'Standard - 8GB RAM/4 CPU' and Environment: 'Default Astrophysics' (image). |
There was a problem hiding this comment.
Just realized I didn't change the date. But the runtime will increase after #360 gets fixed, so I think I'll wait til then to update again.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
Clean up comments and formatting 593bf91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.