Match GCN Circular references with parentheses, periods, and pound signs

Fixes #51.

---------

Co-authored-by: Leo Singer <leo.singer@ligo.org>

.gitattributes

@@ -1,2 +1,3 @@
+src/replacements/*/*.md -text
 src/replacements/*/*.json -text
 src/replacements/*/*.html -text

src/replacements/gcn-circular/index.ts

@@ -5,8 +5,8 @@ function normalize(match: string) {
   return parseFloat(match.replace(/a$/i, '.5'))
 }
 
-const preamble = /GCN(?:s|\s+Circulars?|\s+Circs?\.)?\s*/.source
-const conjunction = /(?:\s*|,|and)+/.source
+const preamble = /GCN(?:s|\s+Circulars?|\s+Circs?\.?)?\s*(?:#)?/gi.source
+const conjunction = /(?:\s*#?|,|and\s*#?)+/.source
 const circularIdRegExp = /\d+(?:a|\.5)?/gi
 const circularId = circularIdRegExp.source
 const legacyUrlOrigin = /https?:\/\/gcn\.gsfc\.nasa\.gov/.source
@@ -17,7 +17,7 @@ const url = `${urlOrigin}/circulars/(${circularId})`
 
 export default {
   find: new RegExp(
-    `${url}|${legacyUrl}|(?<=^|\\s)(?:${preamble}${circularId}(?:${conjunction}${circularId})*)`,
+    `${url}|${legacyUrl}|(?<=^|\\s|\\()(?:${preamble}${circularId}(?:${conjunction}${circularId})*)`,
     'gi'
   ),
   replace(data, value, circularIdFromUrl, circularIdFromLegacyUrl) {

src/replacements/gcn-circular/test.html

@@ -5,4 +5,46 @@ <h1>Hello, world</h1>
 <p>And even really weird legacy URLs work: <data class="gcn-circular" value="33567">https://gcn.gsfc.nasa.gov/gcn/gcn/gcn/gcn3/33567.gcn3</data></p>
 <p>GCN Circ. <data class="gcn-circular" value="789">789</data> and GCN Circs. <data class="gcn-circular" value="3">3</data> and <data class="gcn-circular" value="4">4</data></p>
 <p>And this one refers to GCNs <data class="gcn-circular" value="1">1</data>, <data class="gcn-circular" value="23.5">23a</data>, <data class="gcn-circular" value="45.5">45.5</data> and <data class="gcn-circular" value="42">42</data></p>
-<p>This is not a Circular: http://gcn.gsfc.nasa.gov/gcn/other/971227.gcn3</p>
+<p>This is not a Circular: http://gcn.gsfc.nasa.gov/gcn/other/971227.gcn3</p>
+<p>All of these minor variations with parentheses, octothorpes, character casing, and periods, and different conjunctions are also supported:
+GCN <data class="gcn-circular" value="123">123</data>
+GCN #<data class="gcn-circular" value="123">123</data>
+(GCN <data class="gcn-circular" value="123">123</data>)
+(GCN #<data class="gcn-circular" value="123">123</data>)
+GCN circ. <data class="gcn-circular" value="123">123</data>
+GCN circ. #<data class="gcn-circular" value="123">123</data>
+(GCN circ. #<data class="gcn-circular" value="123">123</data>)
+GCN circ <data class="gcn-circular" value="123">123</data>
+(GCN circ <data class="gcn-circular" value="123">123</data>)
+GCN Circ. <data class="gcn-circular" value="123">123</data>
+GCN Circ. #<data class="gcn-circular" value="123">123</data>
+(GCN Circ. #<data class="gcn-circular" value="123">123</data>)
+GCN Circ <data class="gcn-circular" value="123">123</data>
+(GCN Circ <data class="gcn-circular" value="123">123</data>)
+GCN Circular <data class="gcn-circular" value="123">123</data>
+GCN Circular #<data class="gcn-circular" value="123">123</data>
+(GCN Circular <data class="gcn-circular" value="123">123</data>)
+(GCN Circular #<data class="gcn-circular" value="123">123</data>)
+GCN Circs <data class="gcn-circular" value="123">123</data>, <data class="gcn-circular" value="456">456</data>
+GCN Circs. <data class="gcn-circular" value="123">123</data>, <data class="gcn-circular" value="456">456</data>
+GCN Circs #<data class="gcn-circular" value="123">123</data>, #<data class="gcn-circular" value="456">456</data>
+(GCN Circs #<data class="gcn-circular" value="123">123</data>, #<data class="gcn-circular" value="456">456</data>)
+(GCN Circs <data class="gcn-circular" value="123">123</data>, <data class="gcn-circular" value="456">456</data>)
+GCN Circ <data class="gcn-circular" value="123">123</data>, <data class="gcn-circular" value="456">456</data>
+GCN Circ. <data class="gcn-circular" value="123">123</data>, <data class="gcn-circular" value="456">456</data>
+GCN Circ #<data class="gcn-circular" value="123">123</data>, #<data class="gcn-circular" value="456">456</data>
+(GCN Circ <data class="gcn-circular" value="123">123</data>, <data class="gcn-circular" value="456">456</data>)
+GCN circs <data class="gcn-circular" value="123">123</data>, <data class="gcn-circular" value="456">456</data>
+GCN circs. <data class="gcn-circular" value="123">123</data>, <data class="gcn-circular" value="456">456</data>
+GCN circs #<data class="gcn-circular" value="123">123</data>, #<data class="gcn-circular" value="456">456</data>
+(GCN circs <data class="gcn-circular" value="123">123</data>, <data class="gcn-circular" value="456">456</data>)
+GCN circs <data class="gcn-circular" value="123">123</data> and <data class="gcn-circular" value="456">456</data>
+GCN circs. <data class="gcn-circular" value="123">123</data> and <data class="gcn-circular" value="456">456</data>
+GCN circs #<data class="gcn-circular" value="123">123</data> and #<data class="gcn-circular" value="456">456</data>
+(GCN circs <data class="gcn-circular" value="123">123</data> and <data class="gcn-circular" value="456">456</data>)
+GCN circs <data class="gcn-circular" value="123">123</data> <data class="gcn-circular" value="456">456</data>
+GCN circs. <data class="gcn-circular" value="123">123</data> <data class="gcn-circular" value="456">456</data>
+GCN circs #<data class="gcn-circular" value="123">123</data> #<data class="gcn-circular" value="456">456</data>
+(GCN circs <data class="gcn-circular" value="123">123</data> <data class="gcn-circular" value="456">456</data>)
+GCN #<data class="gcn-circular" value="123">123</data>
+gcn <data class="gcn-circular" value="123">123</data></p>