tweaks to chromatic settings

nasa-jpl · Jul 10, 2024 · 1da0d4b · 1da0d4b
1 parent 4e5929e
commit 1da0d4b
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/storybook.yml b/.github/workflows/storybook.yml
@@ -80,7 +80,7 @@ jobs:
              "pnpm --filter @explorer-1/vue-storybook start" \
              "pnpm --filter @explorer-1/vue-storybook test:ci"
 
-  publish-to-chromatic:
+  publish:
     needs: [build, a11y-tests]
     timeout-minutes: 30
     runs-on: ubuntu-latest
@@ -113,6 +113,7 @@ jobs:
         with:
           projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
           token: ${{ secrets.GITHUB_TOKEN }}
-          storybookBuildDir: 'apps/vue-storybook/storybook_compiled'
-          zip: true
+          storybookBaseDir: 'apps/vue-storybook'
+          storybookBuildDir: 'storybook_compiled'
+          exitZeroOnChanges: true,
           exitOnceUploaded: true
diff --git a/apps/vue-storybook/chromatic.config.json b/apps/vue-storybook/chromatic.config.json
@@ -1,7 +1,8 @@
 {
   "buildScriptName": "build",
   "projectId": "Project:668c47cbeb95392cd79c3c0d",
+  "exitZeroOnChanges": true,
   "storybookBaseDir": "apps/vue-storybook",
-  "storybookBuildDir": "apps/vue-storybook/storybook_compiled",
+  "storybookBuildDir": "storybook_compiled",
   "zip": true
 }
diff --git a/packages/vue/src/components/BaseImage/BaseImage.vue b/packages/vue/src/components/BaseImage/BaseImage.vue
@@ -111,6 +111,7 @@ export default defineComponent({
       :width="width"
       :height="height"
       :loading="loading"
+      data-chromatic="ignore"
       @error="imageFailed"
     />
   </div>

diff --git a/packages/vue/src/components/BaseTimer/BaseTimer.vue b/packages/vue/src/components/BaseTimer/BaseTimer.vue
@@ -34,6 +34,7 @@
           <span
             class="text-stats-xl"
             :class="{ 'text-seconds': unit === 'seconds' }"
+            data-chromatic="ignore"
           >
             <template v-if="countdown && isPast">00</template>
             <template v-else>{{ unitValue(unit) }}</template>

diff --git a/packages/vue/src/components/BaseVideo/BaseVideo.vue b/packages/vue/src/components/BaseVideo/BaseVideo.vue
@@ -15,6 +15,7 @@
         :playsinline="autoplay"
         :autoplay="autoplay"
         :controls="!autoplay"
+        data-chromatic="ignore"
       >
         <template v-if="data.fileWebm">
           <source