fixing alignment in NavHeading, linking Education in NasDesktopEdu to…

… education homepage
nasa-jpl · Aug 7, 2024 · 96c1636 · 96c1636
1 parent d2840e6
commit 96c1636
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/packages/vue/src/components/NavDesktopEdu/NavDesktopEdu.stories.js b/packages/vue/src/components/NavDesktopEdu/NavDesktopEdu.stories.js
@@ -56,16 +56,8 @@ export const NavDesktopDropdownContentData = {
       description: 'Lorem ipsum dolor sit amet.',
       title: 'About'
     },
-    {
-      ...MenuLinkColumnWithHeaderData,
-      heading: null,
-      headingPage: null
-    },
-    {
-      ...MenuLinkColumnWithHeaderData,
-      heading: null,
-      headingPage: null
-    }
+    MenuLinkColumnWithHeaderData,
+    MenuLinkColumnWithHeaderData
   ]
 }
 // combined dropdown data for "more" menu

diff --git a/packages/vue/src/components/NavDesktopEdu/NavDesktopEdu.vue b/packages/vue/src/components/NavDesktopEdu/NavDesktopEdu.vue
@@ -26,7 +26,14 @@
         </NavLogoLinks>
         <!-- site title -->
         <div class="ml-2 pl-3 xl:ml-3 xl:pl-5 border-l border-white border-opacity-30 z-20">
-          <span class="text-white font-bold text-2xl xl:text-3xl">Education</span>
+          <BaseLink
+            class="text-white font-bold text-2xl xl:text-3xl"
+            to="/edu/"
+            link-class="py-2"
+            variant="none"
+          >
+            Education
+          </BaseLink>
         </div>
         <!-- main nav with dropdowns -->
         <nav

diff --git a/packages/vue/src/components/NavHeading/NavHeading.vue b/packages/vue/src/components/NavHeading/NavHeading.vue
@@ -7,7 +7,7 @@
       <BaseLink
         variant="none"
         class="text-subtitle text-jpl-blue-lighter edu:text-primary-lighter inline-block mb-4"
-        link-class="p-2"
+        link-class="px-2 block"
         :to="data.headingPage.url"
       >
         {{ data.heading }}