removing default size from BaseHeading (#504)

nasa-jpl · Jul 19, 2024 · c344b6b · c344b6b
1 parent f0a0305
commit c344b6b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/packages/vue/src/components/BaseHeading/BaseHeading.vue b/packages/vue/src/components/BaseHeading/BaseHeading.vue
@@ -26,7 +26,7 @@ export default defineComponent({
     size: {
       type: String as PropType<HeadingLevel>,
       required: false,
-      default: 'h2',
+      default: '',
       validator: (prop: string): boolean => Object.keys(headings).includes(prop)
     }
   },

diff --git a/packages/vue/src/components/BlockHeading/BlockHeading.vue b/packages/vue/src/components/BlockHeading/BlockHeading.vue
@@ -2,7 +2,6 @@
   <BaseHeading
     v-if="data"
     :level="data.level"
-    :size="data.size"
   >
     {{ data.heading }}
   </BaseHeading>

diff --git a/packages/vue/src/components/BlockStreamfield/BlockStreamfield.stories.js b/packages/vue/src/components/BlockStreamfield/BlockStreamfield.stories.js
@@ -49,6 +49,16 @@ export const BlockStreamfieldData = {
         '<p>Lorem ipsum <a href="/missions/test-mission/">dolor</a> sit amet, consectetur adipiscing elit. Quisque vitae justo quis justo malesuada molestie. Cras sed tincidunt dui.</p><p>Integer imperdiet blandit neque vitae euismod. Nulla aliquet lacus nibh,  vel tincidunt urna efficitur non. In et eros vitae ex posuere maximus  quis eget urna. Suspendisse fringilla posuere velit sit amet posuere.  Morbi malesuada bibendum vehicula. Donec faucibus ut erat ut mattis.  Suspendisse ornare, quam at placerat cursus, dolor mi lacinia nunc, eget  maximus augue nulla in dolor.</p>\n'
     },
     BlockInlineImageData.block,
+    {
+      blockType: 'HeadingBlock',
+      heading: 'Heading 2',
+      level: 'h2'
+    },
+    {
+      blockType: 'HeadingBlock',
+      heading: 'Heading 3',
+      level: 'h3'
+    },
     {
       blockType: 'RichTextBlock',
       value: