Skip to content

Commit

Permalink
Fix: secondary nav z-index, main edu nav styles (#508)
Browse files Browse the repository at this point in the history
* fixing borders on main nav and secondary nav in edu theme

* bumping package version to 0.1.4

* restoring a class I didn't need to remove
  • Loading branch information
stephiescastle authored Jul 19, 2024
1 parent e3081f7 commit cf8f068
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 28 deletions.
2 changes: 1 addition & 1 deletion packages/vue/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@explorer-1/vue",
"version": "0.1.3",
"version": "0.1.4",
"private": false,
"publishConfig": {
"access": "public"
Expand Down
26 changes: 0 additions & 26 deletions packages/vue/src/components/NavDesktopEdu/NavDesktopEdu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,11 @@
'transition-transform': scrollTop > 0 && scrolledCurrentPage, // If not at the top of the page, just transition the transform to prevents content from peeking through on header reveal.
'transform -translate-y-full': !scrolledUp && !headerVisible,
'-scrolled transform translate-y-0': scrolledUp && headerVisible && scrollTop > 0,
'-transparent': invert,
'-hasSecondary': !headerStore?.highlightPrimary
}"
>
<!-- navbar -->
<div class="header-bg z-10 max-w-screen-3xl absolute inset-0 mx-auto"></div>
<div class="bg-primary z-0 absolute right-0 w-1/2 top-0 bottom-0"></div>
<div class="px-4">
<div class="h-18 container flex items-center justify-between mx-auto">
<!-- branding -->
Expand Down Expand Up @@ -287,29 +285,5 @@ export default defineComponent({
}
}
}
&.-scrolled {
@apply border-b border-gray-mid border-opacity-50 bg-white;
&.-transparent {
> .header-bg {
@apply opacity-0 bg-white;
}
.main-navigation {
> * {
@apply text-gray-dark;
.NavDesktopDropdown > button {
text-shadow: none;
}
}
}
}
&.-hasSecondary {
@apply border-0 border-transparent;
}
}
}
</style>
2 changes: 1 addition & 1 deletion packages/vue/src/components/NavSecondary/NavSecondary.vue
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export default defineComponent({
<style lang="scss">
.NavSecondary {
top: -1px; // for intersection observer to work
@apply sticky z-50 w-full bg-white border-b border-gray-mid border-opacity-0 transition-border-opacity duration-150 ease-in;
@apply sticky z-50 w-full bg-white border-b edu:border-0 border-gray-mid border-opacity-0 transition-border-opacity duration-150 ease-in;
@apply hidden;
@screen lg {
@apply block;
Expand Down

0 comments on commit cf8f068

Please sign in to comment.