Skip to content

Commit

Permalink
Fix/edu search placeholder text (#640)
Browse files Browse the repository at this point in the history
* modifying the placeholder text for EDU NavSearchForm

* modifying same placeholder text for mobile nav
  • Loading branch information
stephiescastle committed Sep 26, 2024
1 parent efd1d64 commit d6b60e0
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@
>
<NavSearchForm
class="w-full"
placeholder="Search JPL Education"
@clear-search="closeSearch()"
@submit-form="closeSearch()"
/>
Expand Down
1 change: 1 addition & 0 deletions packages/vue/src/components/NavMobile/NavMobile.vue
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
<!-- search input goes here -->
<NavSearchForm
mobile
:placeholder="themeStore.isEdu ? 'Search JPL Education' : undefined"
class="px-4 my-5"
@submit-form="closeMenu()"
/>
Expand Down
6 changes: 4 additions & 2 deletions packages/vue/src/components/NavSearchForm/NavSearchForm.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ const themeStore = useThemeStore()
interface NavSearchFormProps {
mobile?: boolean
placeholder?: string
}
const props = withDefaults(defineProps<NavSearchFormProps>(), {
mobile: false
mobile: false,
placeholder: 'Search JPL'
})
const emit = defineEmits(['clearSearch', 'submitForm'])
Expand All @@ -35,7 +37,7 @@ const submitSearch = () => {
>
<SearchInput
v-model="searchQuery"
placeholder="Search JPL"
:placeholder="placeholder"
:underlined-input="!props.mobile"
:underlined-input-value="searchQuery"
:auto-focus="!props.mobile"
Expand Down

0 comments on commit d6b60e0

Please sign in to comment.