Skip to content

Commit

Permalink
Fix/dsn widget (#544)
Browse files Browse the repository at this point in the history
* using fetch version of dsn widget

* bumping versions for release
  • Loading branch information
stephiescastle authored Aug 15, 2024
1 parent 378bc25 commit da17b48
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 4 deletions.
4 changes: 4 additions & 0 deletions apps/vue-storybook/.storybook/_mock-components.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// import and assign mock components
import { action } from '@storybook/addon-actions'
import DsnWidget from '@explorer-1/vue/src/components/DsnWidget/DsnWidget.vue'

export default (app) => {
// nuxt-link mock component
Expand All @@ -18,4 +19,7 @@ export default (app) => {
template:
'<a href="#" @click.prevent="log()" :class="this.class" v-bind="$attrs"><slot></slot></a>'
})

// use static dsn widget instead of fetch
app.component('FetchDsnWidget', DsnWidget)
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"publishConfig": {
"access": "public"
},
"version": "3.2.10",
"version": "3.2.13",
"type": "module",
"description": "Monorepo for JPL's design system, Explorer 1",
"keywords": [
Expand Down
2 changes: 1 addition & 1 deletion packages/vue/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@explorer-1/vue",
"version": "0.2.10",
"version": "0.2.13",
"private": false,
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/vue/src/components/DsnWidget/DsnWidget.vue
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
</span>
<span
v-if="data.location"
class="mr-1"
class="mr-1 mt-.5"
aria-hidden="true"
>
{{ data.location }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
</template>
</div>
<!-- DSN Widget -->
<DsnWidget />
<FetchDsnWidget />
<!-- asteroid watch -->
<div
v-if="asteroidWatch"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
</template>
<script lang="ts">
// relative link to view past events assumes that this component will only be used on an events index page.
// @ts-nocheck
// @ts-expect-error Elastic search response is not fully typed
import { defineComponent } from 'vue'
import type { ElasticSearchPage } from '../../interfaces'
import MixinCarousel from './../MixinCarousel/MixinCarousel.vue'
Expand Down
1 change: 1 addition & 0 deletions packages/vue/src/interfaces.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export interface ImageObject {
export interface ImageBlock extends BlockData, ImageObject {}

export interface ElasticSearchPage {
_source: string
id: string | number
content_type: string
url: string
Expand Down

0 comments on commit da17b48

Please sign in to comment.