Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more colors to tailwind.config.js #236

Merged
merged 2 commits into from
May 25, 2022
Merged

Conversation

stephiescastle
Copy link
Member

Checklist

  • Include a description of your pull request and instructions for the reviewer to verify your work.
  • Link to the issue if this PR is issue-specific.
  • Create/update the corresponding story if this includes a UI component.
  • Create/update documentation. If not included, tell us why.
  • List the environments / browsers in which you tested your changes.
  • Tests, linting, or other required checks are passing.
  • PR has an informative and human-readable title
    • PR titles are used to generate the change log in releases; good ones make that easier to scan.
    • PRs will be broadly categorized in the change log, but for even easier scanning, consider prefixing with a component name or other useful categorization, e.g., "BaseButton: fix layout bug", or "Storybook: Update dependencies".
  • PR has been tagged with a SemVer label and a general category label, or skip-changelog.
    • These tags are used to do the aforementioned broad categorization in the change log and determine what the next release's version number should be.
    • Release Drafter will attempt to do the category labeling for you! Please double-check its work.

Description

This PR adds the following colors to our TailwindCSS config:

  • jpl-red-darker #5C0411
  • jpl-sky-blue #53C8ED
  • jpl-sky-blue-dark #0080A4
  • off-white #FAFAFA

These were originally in use only on WCP, but WWW will need the off-white color for the tertiary nav. This is also prep work for #9.

I was going to include the infrastructure for internal vs external themes with this change as well, but it requires a bit more thought and code changes, and I'd like to get the colors in before that.

Instructions to test

The colors are documented in the Storybook:

  1. npm run storybook
  2. View Foundation > Colors

Tested in the following environments/browsers:

Operating System

  • macOS
  • iOS
  • iPadOS
  • Windows

Browser

  • Chrome
  • Firefox ESR
  • Firefox
  • Safari
  • Edge

@stephiescastle stephiescastle added enhancement New feature or request minor Contains new features or enhancements labels May 19, 2022
@stephiescastle stephiescastle changed the title Adding more colors to tailwind config Adding more colors to tailwind.config.js May 19, 2022
@github-actions github-actions bot added feature storybook This issue relates to Storybook.js labels May 19, 2022
@stephiescastle stephiescastle requested a review from a team May 19, 2022 16:52
tailwind.config.js Outdated Show resolved Hide resolved
@stephiescastle stephiescastle merged commit 8c818e4 into main May 25, 2022
@stephiescastle stephiescastle deleted the feature/adding-colors branch May 25, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature minor Contains new features or enhancements storybook This issue relates to Storybook.js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants